Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled googletest does not work with python3 #8055

Closed
georgthegreat opened this issue Nov 18, 2020 · 2 comments
Closed

Bundled googletest does not work with python3 #8055

georgthegreat opened this issue Nov 18, 2020 · 2 comments
Assignees
Labels
inactive Denotes the issue/PR has not seen activity in the last 90 days. P2 python

Comments

@georgthegreat
Copy link
Contributor

What language does this apply to?

All of the above.

Describe the problem you are trying to solve.

While trying to fix #8053 using @acozzette proposed soluton, I've run into trouble with running ./tests.sh cpp_distcheck: googletest package (1.8.0 plus some local patches) which is bundled as submodule apparently does not work with python3.

At least import sets (deprecates as of python2.6) and print statement (removed in python3) cause troubles.

My development server is running Ubuntu Focal which defaults to python3.

Describe the solution you'd like

Updating googletest to the latest released version (1.10) or just switching to googletest master.
Upon brief investigation, is has fixed most of the syntax errors.

Describe alternatives you've considered

So far, I have installed proxy package python-is-python2 which makes /usr/bin/python to point to python2.

Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Feb 26, 2024
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it.

This issue was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Denotes the issue/PR has not seen activity in the last 90 days. P2 python
Projects
None yet
Development

No branches or pull requests

3 participants