Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size to Map class #8068

Merged
merged 1 commit into from Oct 13, 2021
Merged

Add size to Map class #8068

merged 1 commit into from Oct 13, 2021

Conversation

miyucy
Copy link
Contributor

@miyucy miyucy commented Nov 19, 2020

No description provided.

@google-cla
Copy link

google-cla bot commented Nov 19, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 19, 2020
@miyucy
Copy link
Contributor Author

miyucy commented Nov 19, 2020

@googlebot I signed it!

@JasonLunn
Copy link
Contributor

@miyucy - could you add a unit test?

@miyucy
Copy link
Contributor Author

miyucy commented Oct 12, 2021

@JasonLunn I'm sorry, it my fault. I just added simple tests. Could you review again?

@JasonLunn
Copy link
Contributor

Good test! The unit test you've added shows that the proposed change appears to be missing an equivalent implementation in the JRuby equivalent of map.c

@miyucy
Copy link
Contributor Author

miyucy commented Oct 12, 2021

@JasonLunn Thanks for review. I wasn't look JRuby build log.. I added annotation like RubyRepeatedField.java. Could you review it again?

@JasonLunn
Copy link
Contributor

LGTM

@JasonLunn JasonLunn self-requested a review October 13, 2021 01:41
@acozzette acozzette merged commit 3881f49 into protocolbuffers:master Oct 13, 2021
@acozzette
Copy link
Member

Thanks, @miyucy.

@miyucy miyucy deleted the patch-1 branch October 14, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants