You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The files /BUILD and /protobuf.bzl both load from @rules_python at the top level, which defeats Bazel's lazy fetching of dependencies. This forces projects that depend on Protobuf, but not Python, to need the @rules_python dependency declared.
For /BUILD, I recommend moving the py_library targets into a new file python/BUILD and setting up aliases at the old locations. See PR #7190 for a similar change applied to the Java targets.
For /protobuf.bzl, the py_proto_library() symbol should be moved into an equivalent file under python/. Doing this as a breaking change would be easiest since py_proto_library() is unfortunately a macro, but it may also be possible to replace it with a rule and thereby maintain the existing API.
The text was updated successfully, but these errors were encountered:
We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.
This issue is labeled inactive because the last activity was over 90 days ago.
We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it.
This issue was closed and archived because there has been no new activity in the 14 days since the inactive label was added.
The files
/BUILD
and/protobuf.bzl
both load from@rules_python
at the top level, which defeats Bazel's lazy fetching of dependencies. This forces projects that depend on Protobuf, but not Python, to need the@rules_python
dependency declared.For
/BUILD
, I recommend moving thepy_library
targets into a new filepython/BUILD
and setting up aliases at the old locations. See PR #7190 for a similar change applied to the Java targets.For
/protobuf.bzl
, thepy_proto_library()
symbol should be moved into an equivalent file underpython/
. Doing this as a breaking change would be easiest sincepy_proto_library()
is unfortunately a macro, but it may also be possible to replace it with a rule and thereby maintain the existing API.The text was updated successfully, but these errors were encountered: