Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/BUILD and /protobuf.bzl have unnecessarily hard dependencies on rules_python #8100

Closed
jmillikin-stripe opened this issue Nov 30, 2020 · 2 comments
Labels
bazel inactive Denotes the issue/PR has not seen activity in the last 90 days.

Comments

@jmillikin-stripe
Copy link
Contributor

The files /BUILD and /protobuf.bzl both load from @rules_python at the top level, which defeats Bazel's lazy fetching of dependencies. This forces projects that depend on Protobuf, but not Python, to need the @rules_python dependency declared.

For /BUILD, I recommend moving the py_library targets into a new file python/BUILD and setting up aliases at the old locations. See PR #7190 for a similar change applied to the Java targets.

For /protobuf.bzl, the py_proto_library() symbol should be moved into an equivalent file under python/. Doing this as a breaking change would be easiest since py_proto_library() is unfortunately a macro, but it may also be possible to replace it with a rule and thereby maintain the existing API.

@elharo elharo added the bazel label Aug 30, 2021
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Feb 26, 2024
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it.

This issue was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel inactive Denotes the issue/PR has not seen activity in the last 90 days.
Projects
None yet
Development

No branches or pull requests

2 participants