Port for php8 #8105
Merged
Port for php8 #8105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeBoring
force-pushed
the
php8-fix
branch
2 times, most recently
from
a3a4767
to
eaaa26a
Compare
|
Very nice change. I don't see any Kokoro results for PHP 8.0? |
|
It doesn't show up, maybe because I opened this PR before I added the CI. |
haberman
approved these changes
Dec 4, 2020
haberman
added a commit
to haberman/protobuf
that referenced
this pull request
Dec 11, 2020
Message accessors will return null when when the field is not set, so this should be reflected in the PhpDoc. Also updated the code generator for the well-known types to reflect the edits made in protocolbuffers#8105. Also explicitly check for upb_msg_has() in the oneof accessor, so we are not implicitly relying on unset message fields returning NULL at the upb level.
TeBoring
pushed a commit
that referenced
this pull request
Jan 7, 2021
Message accessors will return null when when the field is not set, so this should be reflected in the PhpDoc. Also updated the code generator for the well-known types to reflect the edits made in #8105. Also explicitly check for upb_msg_has() in the oneof accessor, so we are not implicitly relying on unset message fields returning NULL at the upb level.
10 tasks
This was referenced Jan 26, 2021
bshaffer
reviewed
Feb 2, 2021
| @@ -6,10 +6,10 @@ | |||
| "homepage": "https://developers.google.com/protocol-buffers/", | |||
| "license": "BSD-3-Clause", | |||
| "require": { | |||
| "php": ">=5.5.0" | |||
| "php": ">=7.0.0" | |||
There was a problem hiding this comment.
This drops support for 5.5 and 5.6 in the native PHP library. Was this intentional? I see no mention of this anywhere in the PR or README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compare_objects, which was changed tocomparein php runtime.