Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MessageToDict convert map keys to strings #8122

Merged
merged 1 commit into from Oct 14, 2021
Merged

Make MessageToDict convert map keys to strings #8122

merged 1 commit into from Oct 14, 2021

Conversation

mamapanda
Copy link
Contributor

According to the language guide, the JSON map keys should be in string form.

@google-cla google-cla bot added the cla: yes label Dec 4, 2020
@deannagarcia deannagarcia self-requested a review October 14, 2021 18:12
@deannagarcia
Copy link
Member

Thank you for this contribution, merging now!

@deannagarcia deannagarcia merged commit 12f70b7 into protocolbuffers:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deannagarcia deannagarcia deannagarcia approved these changes

Assignees
No one assigned
Labels
cla: yes python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mamapanda @deannagarcia @acozzette @protobuf-kokoro