Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Add macOS big sur compatibility #8126

Merged
merged 1 commit into from Dec 7, 2020

Conversation

atomiix
Copy link
Contributor

@atomiix atomiix commented Dec 6, 2020

In macOS big sur, sysconfig.get_config_var('MACOSX_DEPLOYMENT_TARGET') is returning 11 as an integer which is incompatible with pkg_resources.parse_version().

@google-cla
Copy link

google-cla bot commented Dec 6, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Dec 6, 2020
@atomiix
Copy link
Contributor Author

atomiix commented Dec 6, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Dec 6, 2020
@atomiix atomiix changed the title Add macOS big sur compatibility [python] Add macOS big sur compatibility Dec 6, 2020
@atomiix atomiix changed the base branch from 3.14.x to master December 6, 2020 14:37
@lumaxis
Copy link

lumaxis commented Dec 6, 2020

Running into this too and the fix looks good to me 👍🏼
@atomiix Looks like this PR needs the python label to make the bot happy.

@atomiix
Copy link
Contributor Author

atomiix commented Dec 6, 2020

@lumaxis I'd like to but it seems that I have no right to add labels 😕

@acozzette acozzette merged commit 26c0fbc into protocolbuffers:master Dec 7, 2020
@acozzette
Copy link
Member

Thanks, @atomiix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants