Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] add support for field option "[deprecated=true]" #8211

Closed
cawolf opened this issue Jan 15, 2021 · 2 comments · Fixed by #8223
Closed

[PHP] add support for field option "[deprecated=true]" #8211

cawolf opened this issue Jan 15, 2021 · 2 comments · Fixed by #8223

Comments

@cawolf
Copy link
Contributor

cawolf commented Jan 15, 2021

What language does this apply to?
PHP (using proto3 with protoc-gen-php)

Describe the problem you are trying to solve.
As a developer of a service client, I would like to be able to identify deprecated message fields instantly in order to not use them anymore and replace them correctly.

Describe the solution you'd like
This could be implemented by adding a @deprecated annotation to the field accessors of the generated code, as already stated in the documentation.

Describe alternatives you've considered
Alternatively, triggering error_log() with a $message_type = E_USER_DEPRECATED would have a similar effect.

Additional context

@TeBoring
Copy link
Contributor

LGTM, would you mind send us a PR?

@cawolf
Copy link
Contributor Author

cawolf commented Jan 21, 2021

Sure, I opened #8223 - but the label check fails immediately, and I am not able to add the labels "php" and "release notes: yes" to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants