Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for deprecated fields to PHP compiler #8223

Merged
merged 2 commits into from Jan 29, 2021
Merged

feat: add support for deprecated fields to PHP compiler #8223

merged 2 commits into from Jan 29, 2021

Conversation

cawolf
Copy link
Contributor

@cawolf cawolf commented Jan 21, 2021

fixes #8211

Please feel free to leave comments for improvements, especially for the compiler part, as I am not fluent in C.

src/google/protobuf/compiler/php/php_generator.cc Outdated Show resolved Hide resolved
src/google/protobuf/compiler/php/php_generator.cc Outdated Show resolved Hide resolved
src/google/protobuf/compiler/php/php_generator.cc Outdated Show resolved Hide resolved
@haberman haberman merged commit f4d0f7c into protocolbuffers:master Jan 29, 2021
@cawolf cawolf deleted the php-deprecation-support branch January 31, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PHP] add support for field option "[deprecated=true]"
3 participants