New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opensourcing kotlin protos #8272
Opensourcing kotlin protos #8272
Conversation
@@ -13,4 +13,4 @@ jobs: | |||
with: | |||
check_filenames: true | |||
skip: ./.git,./conformance/third_party,*.snk,*.pb,*.pb.cc,*.pb.h,./src/google/protobuf/testdata,./objectivec/Tests,./python/compatibility_tests/v2.5.0/tests/google/protobuf/internal | |||
ignore_words_list: "alow,alse,ba,cleare,copyable,cloneable,dedup,dur,errorprone,files',fo,fundementals,hel,importd,inout,leapyear,nd,nin,ois,ons,parseable,process',te,testof,ue,unparseable,wasn,wee,gae,keyserver,objext,od,OptIn" | |||
ignore_words_list: "alow,alse,ba,cleare,copyable,cloneable,dedup,dur,errorprone,files',fo,fundementals,hel,importd,inout,leapyear,nd,nin,ois,ons,parseable,process',te,testof,ue,unparseable,wasn,wee,gae,keyserver,objext,od,optin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be removed? I think this made its way into a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out that the spell check has to have the lowercase version, so this is the fix to the other PR.
<artifactId>protobuf-kotlin-lite</artifactId> | ||
<packaging>bundle</packaging> | ||
|
||
<name>Protocol Buffers [Lite]</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Do we want Kotlin in the name somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how these naming conventions are supposed to work but I copied this from Java because it wasn't java specific either.
<mkdir dir="${generated.sources.dir}"/> | ||
<exec executable="${protoc}"> | ||
<arg value="--java_out=${generated.sources.dir}"/> | ||
<arg value="--proto_path=${protobuf.source.dir}"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should likely expose a kotlin version of all of these proto definitions as they are normally part of the public API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
…ng kotlin generated code for standard protos
Opensourcing kotlin protos
Adding kotlin syntax to java protobufs.