Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android stlport and default toolchains to BUILD. #8290

Merged

Conversation

blueshiftlabs
Copy link
Contributor

These are additional possibilities for --crosstool_top for Android NDK
compilation. Since the NDK doesn't have -lpthread, getting these flags
wrong leads to a linker error.

Fixes: 180084220

Copy link
Contributor

@dlj-NaN dlj-NaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick request... the toolchain target names are probably a bit opaque to folks not used to working with Android, so just one request...

@@ -111,6 +111,17 @@ config_setting(
],
)

config_setting(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a comment with a link to https://docs.bazel.build/versions/master/android-ndk.html#configuring-the-stl ?

I think it probably makes sense to insert above this config_setting rule, with a note that it applies to several of them.

These are additional possibilities for --crosstool_top for Android NDK
compilation. Since the NDK doesn't have -lpthread, getting these flags
wrong leads to a linker error.

Fixes: 180084220
@blueshiftlabs
Copy link
Contributor Author

Done, PTAL.

@acozzette acozzette merged commit 255dec1 into protocolbuffers:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants