Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a CMake option to control whether or not RTTI is enabled #8347

Merged
merged 1 commit into from Mar 2, 2021
Merged

Create a CMake option to control whether or not RTTI is enabled #8347

merged 1 commit into from Mar 2, 2021

Conversation

floriansimon1
Copy link

This is useful for Conan recipes that build Protobuf, in which
whatever we want to enable has to be enabled in the initial command line.
Without this, the people maintaining the recipe have to patch the CMake
setup of Protobuf before building the binaries.

Closes #5541

@google-cla
Copy link

google-cla bot commented Feb 25, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

This is useful for Conan recipes that build Protobuf, in which
whatever we want to enable has to be enabled in the initial command line.
Without this, the people maintaining the recipe have to patch the CMake
setup of Protobuf before building the binaries.

Closes #5541
@acozzette
Copy link
Member

Thanks, @floriansimon1.

@floriansimon1
Copy link
Author

My pleasure!

Do we know when the next release is planned?

@acozzette
Copy link
Member

We don't have a set release schedule but we seem to average once every quarter or so. If you want to have this in a release version sooner then feel free to send me another PR cherry-picking this to the 3.15.x branch because we are probably going to do a 3.15.4 release this week.

@floriansimon1
Copy link
Author

floriansimon1 commented Mar 2, 2021 via email

@floriansimon1 floriansimon1 deleted the allow-disabling-rtti-from-cmake-command-line branch March 2, 2021 19:21
@floriansimon1
Copy link
Author

@acozzette > There! #8361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CMake option to define GOOGLE_PROTOBUF_NO_RTTI
3 participants