Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Abilty to pass options to protoc executable from cmake #8374

Merged
merged 1 commit into from Mar 15, 2021
Merged

[CMake] Abilty to pass options to protoc executable from cmake #8374

merged 1 commit into from Mar 15, 2021

Conversation

igor-sirotin
Copy link
Contributor

Added PROTOC_OPTIONS argument to protobuf_generate cmake-function.
This gives ability to pass any required options to protoc executable, e.g. --experimental_allow_proto3_optional, or --proto-path.

@google-cla
Copy link

google-cla bot commented Mar 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Mar 4, 2021
@igor-sirotin
Copy link
Contributor Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Mar 4, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 4, 2021
@igor-sirotin igor-sirotin changed the title Abilty to pass options to protoc executable from cmake [CMake] Abilty to pass options to protoc executable from cmake Mar 4, 2021
@igor-sirotin
Copy link
Contributor Author

Is there anything else I need to do?

@acozzette acozzette merged commit ee35b2d into protocolbuffers:master Mar 15, 2021
@acozzette
Copy link
Member

Thanks, @igor-sirotin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants