Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ::pb namespace (alias). #8423

Merged
merged 1 commit into from Mar 24, 2021
Merged

Remove the ::pb namespace (alias). #8423

merged 1 commit into from Mar 24, 2021

Conversation

dlj-NaN
Copy link
Contributor

@dlj-NaN dlj-NaN commented Mar 23, 2021

This closes #8349, although we will probably still pursue some other name in the future.

@dlj-NaN dlj-NaN requested a review from haberman March 23, 2021 22:09
@google-cla google-cla bot added the cla: yes label Mar 23, 2021
@dlj-NaN dlj-NaN changed the base branch from master to 3.15.x March 23, 2021 23:07
@dlj-NaN dlj-NaN changed the base branch from 3.15.x to master March 23, 2021 23:09
@dlj-NaN
Remove the ::pb namespace (alias).
b8a5b81 
This closes protocolbuffers#8349, although we will probably still pursue some other name in the future.
@dlj-NaN dlj-NaN changed the base branch from master to 3.15.x March 23, 2021 23:15
@dlj-NaN dlj-NaN merged commit 25968de into protocolbuffers:3.15.x Mar 24, 2021
@dlj-NaN dlj-NaN deleted the ns-alias branch March 24, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haberman haberman haberman approved these changes

Assignees
No one assigned
Labels
c++ cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to compile protobufs in pb namespace
3 participants
@dlj-NaN @haberman @protobuf-kokoro