Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UnsafeByteOperations to protobuf-lite #8426

Merged
merged 1 commit into from Mar 24, 2021

Conversation

veblush
Copy link
Contributor

@veblush veblush commented Mar 24, 2021

Adding UnsafeByteOperations to protobuf-lite. UnsafeByteOperations is needed for gRPC Java which relies on protobuf-lite to wrap a ByteBuffer when creating a ByteString. UnsafeByteOperations is a pretty small class so it won't increase the footprint of protobuf-lite much.

@google-cla google-cla bot added the cla: yes label Mar 24, 2021
@perezd
Copy link
Contributor

perezd commented Mar 24, 2021

PTAL at the Mergable error: ❌ (((Please include release notes: yes AND Please include at least a language label (e.g., c++, java, python). Or apply one of the following labels: autotools, bazel, cmake, cleanup, conformance tests, integration, protoc.) OR Please include release notes: no))

@perezd
Copy link
Contributor

perezd commented Mar 24, 2021

Actually, my fault I can do this!

@perezd perezd merged commit aedb8d7 into protocolbuffers:master Mar 24, 2021
@veblush
Copy link
Contributor Author

veblush commented Mar 24, 2021

@perezd Thanks for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants