Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed message equality in cases where the message type is different. #8434

Merged
merged 2 commits into from Apr 1, 2021

Conversation

haberman
Copy link
Member

If the message types are different, equality comparison must return
false.

Fixes: #8427

If the message types are different, equality comparison must return
false.
ruby/ext/google/protobuf_c/message.c Outdated Show resolved Hide resolved
ruby/tests/common_tests.rb Show resolved Hide resolved
Copy link
Member

@fowles fowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haberman haberman changed the base branch from master to 3.15.x April 1, 2021 17:47
@haberman haberman merged commit f3f8707 into protocolbuffers:3.15.x Apr 1, 2021
@haberman haberman deleted the ruby-message-eq branch April 20, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby message class equality changed in 3.15.0
3 participants