Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed memory leak of Ruby arena objects. #8461

Merged
merged 1 commit into from Apr 7, 2021

Conversation

haberman
Copy link
Member

@haberman haberman commented Apr 7, 2021

In our Arena_free() function, we were freeing the memory from the
upb arena but we were failing to free the memory for the
Ruby arena object. This was causing every Ruby arena object
to leak: even though the objects were getting GC'd, the
underlying memory was not getting released.

Fixes: #8455 #8421

In our free() method, we were freeing the memory from the
upb arena but we were failing to free the memory for the
Ruby arena object. This was causing every Ruby arena object
to leak: even though the objects were getting GC'd, the
underlying memory was not getting released.
@haberman haberman requested a review from acozzette April 7, 2021 17:34
@haberman haberman changed the base branch from master to 3.15.x April 7, 2021 17:34
@google-cla google-cla bot added the cla: yes label Apr 7, 2021
@google-cla google-cla bot added the cla: yes label Apr 7, 2021
Copy link

@Visva92 Visva92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory Leak in ruby gem version 3.15.3 and above (including the latest 3.15.7)
4 participants