Fix source gem compilation #8471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozzette
reviewed
Apr 9, 2021
This should allow gem installation when `bundle config force_ruby_platform true` has been set. It has the unfortunate side effect of printing the protoc version during build, but a quiet cross-platform solution is more complicated.
jamesgecko
force-pushed
the
jd/fix-ruby-compile
branch
from
f808707
to
dce61c9
Compare
|
Thanks, @jamesgecko. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should fix #8372. It does two things:
protocwhen building the source gem, as the specified../src/protocbinary does not exist in the source gem.This does not allow the gem to be built directly from git in a Gemfile (eg,
gem 'google-protobuf', github: 'protocolbuffers/protobuf'), but it should allow the gem to be built successfully whenbundle config force_ruby_platform truehas been set.