Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused python_protobuf.{cc,h} #8513

Merged
merged 2 commits into from Apr 19, 2021

Conversation

georgthegreat
Copy link
Contributor

@georgthegreat georgthegreat commented Apr 19, 2021

This is a continuation of #8510.

@georgthegreat
Copy link
Contributor Author

As I see, the file still participates in build:

make[1]: *** No rule to make target 'python/google/protobuf/internal/python_protobuf.cc', needed by 'distdir'.  Stop.

I wonder how it this works.

@acozzette
Copy link
Member

I think this line probably just needs to be deleted.

@georgthegreat
Copy link
Contributor Author

georgthegreat commented Apr 20, 2021

@acozzette, I see that google/protobuf/util/init.py does not makes anything useful either.

Could you check if it can be removed too?

@acozzette
Copy link
Member

I'm not sure. @anandolee Do you know if that file can be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants