Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc maven artifacts: reuse osx-x86_64 for osx-aarch_64 #8557

Merged
merged 1 commit into from Jun 2, 2021

Conversation

yuzawa-san
Copy link
Contributor

Fixes google/protobuf-gradle-plugin#492

The main rationale is to fix this and not have users need to manually and/or conditionally point at the x86_64 classifier. The M1 macs are able to run x86_64 binaries in rosetta compatibility mode.

@ejona86 had a good idea, so I attempt here to upload the same file used in the osx-x86_64 classifier for the osx-aarch_64 classifier.

One day if a native M1 build comes along and solves this, modify this to upload a real M1 build.

Signed-off-by: James Yuzawa <jtyuzawa@gmail.com>
@google-cla
Copy link

google-cla bot commented May 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 4, 2021
@yuzawa-san
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels May 4, 2021
KevinRoebert added a commit to drasyl/drasyl that referenced this pull request May 6, 2021
@fowles fowles requested a review from perezd May 7, 2021 18:18
@ghost
Copy link

ghost commented Jun 2, 2021

@perezd Could you look over this MR quickly? I think the review is going pretty fast here and many could benefit from it.

@yuzawa-san
Copy link
Contributor Author

The checks say the PR is missing a label, which I cannot add, so can the admins please add one (maybe java)?

@fowles fowles removed the request for review from perezd June 2, 2021 20:36
@fowles
Copy link
Member

fowles commented Jun 2, 2021

@perezd Could you look over this MR quickly? I think the review is going pretty fast here and many could benefit from it.

He is on vacation at the moment, but I reviewed it.

@fowles fowles merged commit b650ea4 into protocolbuffers:master Jun 2, 2021
@yuzawa-san yuzawa-san deleted the osx-m1-fix branch June 2, 2021 20:40
KevinRoebert added a commit to drasyl/drasyl that referenced this pull request Jun 8, 2021
anthonydahanne added a commit to anthonydahanne/sbt-protoc that referenced this pull request Oct 18, 2021
* versions from 3.17.3 upwards support the Mac M1 architecture (osx-aarch_64), and allow native usage of sbt on a Mac M1, see protocolbuffers/protobuf#8557
acozzette added a commit to acozzette/protobuf that referenced this pull request Nov 8, 2021
These are still x86-64 binaries at the moment (see protocolbuffers#8557), but should be
usable on M1 Macs in the Rosetta compatibility mode. Let's start
publishing them on our GitHub release page and then eventually we can
make them into true x86-64 binaries.

This fixes protocolbuffers#9200.
acozzette added a commit to acozzette/protobuf that referenced this pull request Nov 8, 2021
These are still x86-64 binaries at the moment (see protocolbuffers#8557), but should be
usable on M1 Macs in the Rosetta compatibility mode. Let's start
publishing them on our GitHub release page and then eventually we can
make them into true aarch_64 binaries.

This fixes protocolbuffers#9200.
acozzette added a commit that referenced this pull request Nov 8, 2021
These are still x86-64 binaries at the moment (see #8557), but should be
usable on M1 Macs in the Rosetta compatibility mode. Let's start
publishing them on our GitHub release page and then eventually we can
make them into true aarch_64 binaries.

This fixes #9200.
github-brice-jaglin added a commit to github-brice-jaglin/sbt-protoc that referenced this pull request Dec 2, 2021
@ptrdom
Copy link

ptrdom commented Mar 18, 2022

Could this approach be backported to latest 2.x release?

@santy-b
Copy link

santy-b commented Nov 18, 2022

I ran into this issue, and the following fixed it for me.

softwareupdate --install-rosetta

This allows for Macs with M1 chips to run in Intel compatibility mode.

@JackyAnn
Copy link

jacky@jacky-mac Downloads % ./protoc-gen-grpc-java-osx-aarch_64.exe
zsh: bad CPU type in executable: ./protoc-gen-grpc-java-osx-aarch_64.exe

can not executable on mac m2 chips
version:
protoc-gen-grpc-java-1.58.0-osx-aarch_64.exe

@ejona86
Copy link
Contributor

ejona86 commented Oct 18, 2023

@JackyAnn, that is grpc/grpc-java#7690

@JackyAnn
Copy link

Thank you @ejona86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protoc-gen-grpc-java not available on apple m1 Support for Apple M1 processors
7 participants