Update ruby_generator.cc to allow proto2 imports in proto3 #9003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangskz
changed the title
|
This looks great. Could you also add a test in one of these protos, to ensure that the generated code can be successfully loaded into a Ruby process and used? https://github.com/protocolbuffers/protobuf/tree/master/ruby/tests I think this is a good candidate; you could make this file import one of the proto2 protos from this directory: https://github.com/protocolbuffers/protobuf/blob/master/ruby/tests/basic_test.proto Then add a test in https://github.com/protocolbuffers/protobuf/blob/master/ruby/tests/basic.rb |
haberman
approved these changes
Sep 22, 2021
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
…uffers#9003) * Update ruby_generator.cc to allow proto2 imports in proto3, with updated unit tests * Update Makefile.am with new ruby_generated_code_proto2_import.proto * Fix ruby_generator unit test to use temporary test directory for imported protos * Add test for imported proto2 to ruby/tests * Fix proto_path, restore to ../src/protoc, and fix/cleanup unit test. * Rename Proto2TestMessage to TestImportedMessage for consistency, for ruby compiler tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.