Fix build on AIX and SunOS (#8373)

[scddev]

• fix includes for AIX and SunOS

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[scddev]

@googlebot I signed it!

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[elharo]

Are people still using pre-Solaris SunOS? Or is this for Solaris?

I wonder if we could set up a Github action on one or both of these platforms to test this?

[scddev]

In my case I used Solaris 10, so maybe Solaris would be the better name. I can modify the commit message if you like.

[scddev]

@googlebot I signed it!

[gdharley]

Can we make sure that any AIX fix includes support for xlC and gcc compilers on AIX.

[elharo]

@gdharley Are you asking that we also support xLC and gcc, or are you worried that this might break support that is already working?

[gdharley]

We use gcc on AIX and while protobufs compile, there are linking issues with libstdc++ which means protoc when executed has missing symbols. I have tried linking against every libstdc++ available and always different symbols are missing. Have manually edited the Makefile and can't see anything wrong.

[scddev]

To get around the dependencies to libstdc++ or libgcc we use LDFLAGS -static-libgcc -static-libstdc++.

Btw, we are using the cmake build instead of the autotools build. But also cmake build needs some tweaks to work. For AIX we are using a toolchain file as cmake by default generates some commands wrong (ar, ranlib).

[gdharley]

Thanks Dietmar, I thought I had tried static linking, will try again.
I guess it is all these tweaks that need to be fixed to properly support gcc on AIX.

[scddev]

To get you started, here my toolchain.cmake:

set(CMAKE_C_FLAGS_INIT "-maix64 -pthread")
set(CMAKE_CXX_FLAGS_INIT "-maix64 -pthread")
set(CMAKE_SHARED_LINKER_FLAGS_INIT "-static-libgcc -static-libstdc++ -Wl,-bbigtoc")
set(CMAKE_EXE_LINKER_FLAGS_INIT "-static-libgcc -static-libstdc++ -Wl,-bbigtoc")

set(CMAKE_C_ARCHIVE_CREATE
    "<CMAKE_AR> <LINK_FLAGS> -X64 qc <TARGET> <OBJECTS>")
set(CMAKE_C_ARCHIVE_APPEND
    "<CMAKE_AR> <LINK_FLAGS> -X64 q <TARGET> <OBJECTS>")
set(CMAKE_C_ARCHIVE_FINISH "<CMAKE_RANLIB> -X64 <TARGET>")

set(CMAKE_CXX_ARCHIVE_CREATE
    "<CMAKE_AR> <LINK_FLAGS> -X64 qc <TARGET> <OBJECTS>")
set(CMAKE_CXX_ARCHIVE_APPEND
    "<CMAKE_AR> <LINK_FLAGS> -X64 q <TARGET> <OBJECTS>")
set(CMAKE_CXX_ARCHIVE_FINISH "<CMAKE_RANLIB> -X64 <TARGET>")

Now I can build with:

cd cmake
cmake -S . -B build -DCMAKE_TOOLCHAIN_FILE=toolchain.cmake
cmake --build build

This yields:

$ file build/protoc
build/protoc: 64-bit XCOFF executable or object module not stripped
$ ldd build/protoc
build/protoc needs:
         /opt/freeware/lib/libz.a(libz.so.1)
         /usr/lib/libpthreads.a(shr_xpg5_64.o)
         /usr/lib/libc.a(shr_64.o)
         /unix
         /usr/lib/libcrypt.a(shr_64.o)
$ build/protoc --version
libprotoc 3.18.1

[acozzette]

@scddev Thanks for the fix!