Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf_version.bzl missing from v3.19.0 source archive #9129

Closed
SanjayVas opened this issue Oct 20, 2021 · 1 comment
Closed

protobuf_version.bzl missing from v3.19.0 source archive #9129

SanjayVas opened this issue Oct 20, 2021 · 1 comment
Assignees
@acozzette

Comments

@SanjayVas
Copy link

What version of protobuf and what language are you using?
Version: 3.19.0
Language: Java/Kotlin

What operating system (Linux, Windows, ...) and version?
Linux (Debian Bookworm)

What runtime / compiler are you using (e.g., python version or gcc version)
Bazel + OpenJDK11 + Clang 11.1.0

What did you do?

  1. Update http_archive rule named com_google_protobuf in my Bazel WORKSPACE to point to protobuf v3.19.0 source archive (https://github.com/protocolbuffers/protobuf/releases/download/v3.19.0/protobuf-all-3.19.0.tar.gz)
  2. Attempt to build target with label @com_google_protobuf//:protobuf_java using bazel build command.

What did you expect to see
Build completes successfully.

What did you see instead?

Build fails with the following error snippet:

error loading package '@com_google_protobuf//java/core': cannot load '@com_google_protobuf//:protobuf_version.bzl': no such file and referenced by '@com_google_protobuf//:protobuf_java'

I looked inside the source archive for that release and it appears that indeed protobuf_version.bzl is missing.
acozzette added a commit to acozzette/protobuf that referenced this issue Oct 20, 2021
@acozzette
Ensure that release archives contain everything needed for Bazel
e2235a8 
This change adds some files to EXTRA_DIST in Makefile.am so that our
published tar and zip files will have everything needed for Bazel
builds. I also added a basic test for this so that next time we should
find out sooner if we're missing any important files.

This should fix protocolbuffers#9129.
@acozzette acozzette mentioned this issue Oct 20, 2021
Merged
@acozzette
Copy link
Member

Thank you for the bug report. #9131 should fix this and then I'll make sure the fix is reflected in 3.19.1.

@acozzette acozzette self-assigned this Oct 20, 2021
acozzette added a commit to acozzette/protobuf that referenced this issue Oct 20, 2021
@acozzette
Ensure that release archives contain everything needed for Bazel
9456bc5 
This change adds some files to EXTRA_DIST in Makefile.am so that our
published tar and zip files will have everything needed for Bazel
builds. I also added a basic test for this so that next time we should
find out sooner if we're missing any important files.

This should fix protocolbuffers#9129.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acozzette acozzette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acozzette @SanjayVas