JS: Fixed ReferenceError: window is not defined
#9156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarnixBouhuis
changed the title
ReferenceError: window is not defined for nodejsReferenceError: window is not defined
|
@MarnixBouhuis Thanks! |
acozzette
pushed a commit
to acozzette/protobuf
that referenced
this pull request
Oct 28, 2021
|
MarnixBouhuis:fix/window-undefined |
|
I'll |
This was referenced May 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #8864 introduced a bug (#9152) in generated JS code where it would error getting the global object saying that
windowis undefined.I've missed this scenario in my original PR so this PR is here to make the functionality more robust.
This PR fixes this issue by explicitly checking if window is defined.