Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test scope to kotlin-test for protobuf-kotlin-lite #9518

Merged
merged 1 commit into from Feb 17, 2022
Merged

Add test scope to kotlin-test for protobuf-kotlin-lite #9518

merged 1 commit into from Feb 17, 2022

Conversation

alexvanyo
Copy link
Contributor

I believe this is all that is needed to fix #9517 (this also matches the declaration for protobuf-kotlin:

protobuf/java/kotlin/pom.xml

Line 61 in b0bf163

<scope>test</scope>
)

deannagarcia
deannagarcia approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@deannagarcia deannagarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

@deannagarcia deannagarcia merged commit 972b122 into protocolbuffers:master Feb 17, 2022
@alexvanyo alexvanyo deleted the patch-1 branch February 17, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deannagarcia deannagarcia deannagarcia approved these changes

Assignees
No one assigned
Labels
kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

protobuf-kotlin-lite transitively depends on kotlin-test
4 participants
@alexvanyo @deannagarcia @acozzette @protobuf-kokoro