[C#] fix parse failure for extensions with large field numbers #9591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. Per spec the max extension number is 2^29 - 1, or 536,870,911. |
jskeet
approved these changes
Mar 7, 2022
| @@ -415,6 +415,25 @@ public void TestSlowPathAvoidance() | |||
| } | |||
| } | |||
|
|
|||
| [Test] | |||
There was a problem hiding this comment.
Is there any reason you've added this test in here as well? We don't normally do that.
There was a problem hiding this comment.
Thank you for the review.
I didn't know where to add the test cases, so I added them to both files.
It seems unnecessary, so I'll delete this change.
| @@ -90,7 +90,7 @@ public static WireType GetTagWireType(uint tag) | |||
| /// </summary> | |||
| public static int GetTagFieldNumber(uint tag) | |||
| { | |||
| return (int) tag >> TagTypeBits; | |||
| return (int) (tag >> TagTypeBits); | |||
There was a problem hiding this comment.
Ouch, that was a subtle bug. Thanks for catching it.
|
Great, thanks. I'll squash and merge on green. |
|
This shouldn't affect the MacOS Ruby Release, which is the only target still running. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is failing to parse messages with an extension whose field number is large (> 0x10000000), e.g. https://github.com/google/mediapipe/blob/e6c19885c6d3c6f410c730952aeed2852790d306/mediapipe/calculators/tensor/tensors_to_detections_calculator.proto#L25) because the tag value is cast to
intbefore shifting right.