From 57e09ad84867f88792489b459caddb6482476b0d Mon Sep 17 00:00:00 2001 From: Steve Rago Date: Wed, 17 Mar 2021 10:31:03 -0400 Subject: [PATCH] add error returns missing from protoc to prevent it from exiting with a successful return value when writing the zip file fails --- src/google/protobuf/compiler/command_line_interface.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/google/protobuf/compiler/command_line_interface.cc b/src/google/protobuf/compiler/command_line_interface.cc index b0b2963d2dcd..3705e369c623 100644 --- a/src/google/protobuf/compiler/command_line_interface.cc +++ b/src/google/protobuf/compiler/command_line_interface.cc @@ -586,10 +586,12 @@ bool CommandLineInterface::GeneratorContextImpl::WriteAllToZip( if (stream.GetErrno() != 0) { std::cerr << filename << ": " << strerror(stream.GetErrno()) << std::endl; + return false; } if (!stream.Close()) { std::cerr << filename << ": " << strerror(stream.GetErrno()) << std::endl; + return false; } return true;