Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test with V8 on macOS/x86_64 is not reusing cache #370

Open
PiotrSikora opened this issue Sep 25, 2023 · 2 comments
Open

test with V8 on macOS/x86_64 is not reusing cache #370

PiotrSikora opened this issue Sep 25, 2023 · 2 comments
Assignees

Comments

@PiotrSikora
Copy link
Contributor

It looks that sha256sum was removed (or possibly replaced with gsha256sum?), which broke cache-key evaluation:

echo "::set-output name=uniq::$(bazel query --output build //external:v8 | grep -E 'sha256|commit' | cut -d\" -f2)-$(echo  | sha256sum)"
[...]
/Users/runner/work/_temp/4a550a5e-9186-4641-9bff-d391171da246.sh: line 1: sha256sum: command not found

cc @mpwarres

@mpwarres
Copy link
Contributor

Interesting--I wonder if it's always been that way? sha256sum doesn't exist on MacOS (e.g. ESGF/esg-search#84), but can be done via shasum -a 256.

@mpwarres mpwarres self-assigned this Sep 25, 2023
@PiotrSikora
Copy link
Contributor Author

Actually, it looks that the cache entry exists and it's downloaded, but it doesn't speed up the build process, so something else is broken.

As for sha256sum, it's possible that it was always broken, since it was added to differentiate between sanitizer builds, and we only use them on Linux, so this should be only noise on macOS.

@PiotrSikora PiotrSikora changed the title CI not caching on the macOS due to missing sha256sum test with V8 on macOS/x86_64 is not reusing cache Sep 25, 2023
@PiotrSikora PiotrSikora changed the title test with V8 on macOS/x86_64 is not reusing cache test with V8 on macOS/x86_64 is not reusing cache Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants