Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC callbacks are reentrant, defer them #373

Open
PiotrSikora opened this issue Sep 25, 2023 · 1 comment
Open

gRPC callbacks are reentrant, defer them #373

PiotrSikora opened this issue Sep 25, 2023 · 1 comment

Comments

@PiotrSikora
Copy link
Contributor

gRPC callbacks are reentrant, leading to callback-during-callback, and crashes in SDKs.

Those should be deferred (similarly to callbacks for HTTP callouts, etc.)

Reported in proxy-wasm/proxy-wasm-rust-sdk#206, although plugins would crash even with deferred call due to unregistered token_id.

cc @mpwarres
@erikness-doordash erikness-doordash mentioned this issue Oct 18, 2023
Merged
@PiotrSikora
Copy link
Contributor Author

PiotrSikora commented Nov 7, 2023 •
edited

@mpwarres could you take a stab at fixing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PiotrSikora