Using Prysm BN with the --bootstrap-node with and invalid signature leads to a wrong error message.

[nalepae]

Describe the bug

When running Prysm BN with this option:

--bootstrap-node=enr:-KG4QO33qhw7Erxpg_jJkUkowyDvJ4RtpsEnJuDub2DCkeoI1O5_FDd1cekoZemUn32A3ZmAyX-asvRky3w3GGJe3YQBhGV0aDKQaa4OmQYBcAD__________4JpZIJ2NIJpcITAqAEDiXNlY3AyNTZrMaED3Vk2vm3O1LtlY8VgKj7kUBkQwG81sfpoGQIF5SR4_8ODdGNwgiVYg3VkcIIlVw

we get the following error message:

ERROR p2p: Invalid address of enr:-KG4QO33qhw7Erxpg_jJkUkowyDvJ4RtpsEnJuDub2DCkeoI1O5_FDd1cekoZemUn32A3ZmAyX-asvRky3w3GGJe3YQBhGV0aDKQaa4OmQYBcAD__________4JpZIJ2NIJpcITAqAEDiXNlY3AyNTZrMaED3Vk2vm3O1LtlY8VgKj7kUBkQwG81sfpoGQIF5SR4_8ODdGNwgiVYg3VkcIIlVw provided error=failed to parse multiaddr "enr:-KG4QO33qhw7Erxpg_jJkUkowyDvJ4RtpsEnJuDub2DCkeoI1O5_FDd1cekoZemUn32A3ZmAyX-asvRky3w3GGJe3YQBhGV0aDKQaa4OmQYBcAD__________4JpZIJ2NIJpcITAqAEDiXNlY3AyNTZrMaED3Vk2vm3O1LtlY8VgKj7kUBkQwG81sfpoGQIF5SR4_8ODdGNwgiVYg3VkcIIlVw": must begin with /

The disturbing part is failed to parse multiaddr, since we did not provided a multi-address but an ENR.

When using the ENR dump tool from the devp2p tool, we see that corresponding signature is invalid.

./devp2p enrdump enr:-KG4QO33qhw7Erxpg_jJkUkowyDvJ4RtpsEnJuDub2DCkeoI1O5_FDd1cekoZemUn32A3ZmAyX-asvRky3w3GGJe3YQBhGV0aDKQaa4OmQYBcAD__________4JpZIJ2NIJpcITAqAEDiXNlY3AyNTZrMaED3Vk2vm3O1LtlY8VgKj7kUBkQwG81sfpoGQIF5SR4_8ODdGNwgiVYg3VkcIIlVw
INVALID: invalid signature on node record
Record has sequence number 1 and 6 key/value pairs.
  "eth2"      9069ae0e9906017000ffffffffffffffff
  "id"        "v4"
  "ip"        192.168.1.3
  "secp256k1" a103dd5936be6dced4bb6563c5602a3ee4501910c06f35b1fa68190205e52478ffc3
  "tcp"       9560
  "udp"       9559

So we would expected to get such an invalid signature error message instead of a failed to parse multiaddr error message.

The root cause of this bug is, in parseGenericAddrs, here we get an error, but this error is skipped and shadowed by this error.

A solution would be to first check if the given string has enode:// or enr: prefix. In this case try the enode.Parse method.
In the contrary, try the multiAddrFromStringmethod.