Add template for QueryBuilder #118
Closed
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyRepository provides the template for QueryBuilder
|
See PR that reverted the same changes :) |
|
Oh yeah, didnt saw it. Maybe we could make |
|
I found these snippets: https://psalm.dev/r/245c5181cb<?php
/**
* @template T of mixed
*/
class QueryBuilder
{
/**
* @return static<mixed>
*/
public function select(): self
{
return $this;
}
/**
* @return Query<T>
*/
public function getQuery()
{
return new Query();
}
}
/**
* @template T of mixed
*/
class Query {}
class Foo {}
/** @var QueryBuilder<Foo> $builder */
$builder = new QueryBuilder();
/** @psalm-trace $query1 */
$query1 = $builder->getQuery();
/** @psalm-trace $query2 */
$query2 = $builder->select()->getQuery(); |
Might be a solution the beginning of a solution, but
I would recommend to add some test about the issue #114 to prove your solution will not introduce the regression again. |
|
I found these snippets: https://psalm.dev/r/245c5181cb<?php
/**
* @template T of mixed
*/
class QueryBuilder
{
/**
* @return static<mixed>
*/
public function select(): self
{
return $this;
}
/**
* @return Query<T>
*/
public function getQuery()
{
return new Query();
}
}
/**
* @template T of mixed
*/
class Query {}
class Foo {}
/** @var QueryBuilder<Foo> $builder */
$builder = new QueryBuilder();
/** @psalm-trace $query1 */
$query1 = $builder->getQuery();
/** @psalm-trace $query2 */
$query2 = $builder->select()->getQuery(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #117