doctrine/collections phpstubs outdated/obsolete

[boesing]

Hey there,

doctrine/collection started to introduce generics and stuff.
I actually get some issues from this doctrine plugin as it overrides the non-stub types.

I'll have a look into this when I find some time, just want to raise the issue to keep track of it.

Thanks.

---

Refs:

doctrine/collections v1.7.0

https://github.com/doctrine/collections/blob/07d15c8a766e664ec271ae84e5dfc597aeeb03b1/lib/Doctrine/Common/Collections/Collection.php#L27-L30

https://github.com/doctrine/collections/blob/07d15c8a766e664ec271ae84e5dfc597aeeb03b1/lib/Doctrine/Common/Collections/Selectable.php#L17-L18

[weirdan]

Good, that's how it was intended from the very beginning of this plugin, back when doctrine maintainers were not as receptive to static analysis as they are now.

doctrine/collection started to introduce generics and stuff.

... about 4 years ago actually (in doctrine/collections#177)

We used to have version checks for doctrine/collections, it shouldn't be too hard to selectively disable some stubs using

psalm-plugin-doctrine/src/Plugin.php

Line 68 in 4f62e33

private function hasPackageOfVersion(string $packageName, string $constraints): bool

[kjacquesmashbo]

This is also causing issue for me.

I see this commit: 2.x...disable-collection-stub

Are there any plans to merge this?

[orklah]

We're very short staffed and none of the maintainers actually uses Doctrine these days so we rely on contributors for improving this plugin. If you have some time to spare, you could try making a PR from that to see how the CI reacts :)