Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to choose outdated dependency exit code #43

Open
deleteriousEffect opened this issue Feb 22, 2021 · 3 comments
Open

Enable users to choose outdated dependency exit code #43

deleteriousEffect opened this issue Feb 22, 2021 · 3 comments

Comments

@deleteriousEffect
Copy link

deleteriousEffect commented Feb 22, 2021

Currently, when this job fails in a CI job with an exit code of one, it's difficult to programmatically tell the difference between an outdated dependency and a failure caused by another reason.

This feature called --issues-exit-code, exists on golangci lint: https://golangci-lint.run/usage/configuration/ for example.

@psampaz
Copy link
Owner

psampaz commented Mar 3, 2021

thanks for you suggestion. It seems like a good use case, I think I will accept a PR for this.

@deleteriousEffect
Copy link
Author

@psampaz awesome, I can write one up. Do you want this new flag to exist alongside the current ci flag?

@psampaz
Copy link
Owner

psampaz commented Mar 24, 2021

@deleteriousEffect if what you mean is that the new exit-code flag should require ci flag to be set, then no. Let's keep it simple. I suggest having the default flag value as 1 (as it is now https://github.com/psampaz/go-mod-outdated/blob/master/internal/runner/runner.go#L34) and only of someone wants a different value to actually set it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants