Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate "post_max_size" rule #73

Open
steffenweber opened this issue Sep 2, 2014 · 1 comment
Open

Duplicate "post_max_size" rule #73

steffenweber opened this issue Sep 2, 2014 · 1 comment
Labels

Comments

@steffenweber
Copy link

This rule exists in two places:

  1. https://github.com/psecio/iniscan/blob/master/src/Psecio/Iniscan/rules.json (twice)
  2. https://github.com/psecio/iniscan/blob/master/src/Psecio/Iniscan/Rule/MaximumPostSize.php
== Executing INI Scan [09.02.2014 12:47:18] ==
...
FAIL   | WARNING  |             | post_max_size            | Unless necessary, a maximum post size of 16M is too large
...
PASS   | WARNING  |             | post_max_size            | A maximum post size should be defined to prevent server overload from large requests
FAIL   | WARNING  |             | post_max_size            | The max upload size should not be too high, to prevent server overload from large requests
...

The first and third warning are duplicates.

@enygma
Copy link
Member

enygma commented Sep 2, 2014

Ah, good point - I guess technically it was meant to be two different checks (one to see if it's set, one to see if it's reasonable) but I see no reason why they couldn't be combined into the MaximumPostSize.php and the description changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants