Docker latest_release is pointing to an alpha version

[babyhuey]

The latest docker release on docker hub is pointing to an alpha version. I would have expected latest_release to be the latest release, and not the very latest on git.

Is there a way to fix this to go back to 22.12.0?

[matthewarmand]

Yep seems busted, according to the docs for the official Docker image the latest_release tag should be:

tag created when a new version of Black is released. Recommended for users who want to use released versions of Black. It maps to the latest release of Black.

The latest release of black linked above is 22.12.0 at time of writing, and the latest_release Docker image gives:

$ docker pull pyfound/black:latest_release && docker run -it pyfound/black:latest_release black --version
black, 23.1a1 (compiled: no)
Python (CPython) 3.11.1   

[matthewarmand]

I'm not an expert on Github Workflows, so I could very easily be wrong here, but it seems to me like the trigger line for this docker publish might be the problem.

        if: ${{ github.event_name == 'release' && github.event.action == 'published' }}

This will run on every published release, regardless of latest vs pre_release status, no? Does it also need to include something indicating pre_release == 'false' or something like that? Just going off the release API documentation

[matthewarmand]

According to this support article, that line may need to change to something like:

        if: ${{ github.event_name == 'release' && github.event.action == 'published' && !github.event.release.prerelease }}

But then later on in the thread someone mentions a workflow they have that does not run on preleases, and gives the exact line that currently exists in Black's workflow. So maybe this was an accidental manual push? Or the behavior has changed potentially

[matthewarmand]

Scratch the "manual push", this was clearly triggered by CI: https://github.com/psf/black/actions/runs/3725518068/jobs/6318369959#step:8:176. So seems to me the latest_release trigger in the docker workflow needs to change.

[JelleZijlstra]

@cooperlees do you know how to yank the docker release for 23.1a1? Or at least mark it as not the latest release.

[matthewarmand]

(I'm not who you asked so sorry for the noise but since I'm here anyway) The easiest way is probably for someone on the project with Dockerhub access to re-push the 22.12.0 image to the latest_release tag.

[cooperlees]

Reran the Docker action: https://github.com/psf/black/actions/runs/3658832710/jobs/6334595544

Unfortunately people will have to manually use 23.1a1 to test alpha, but not the worst scenario. I will try find time to cleanup the action for this new alpha workflow so we can't do this again.

PRs welcome if you have a potential fix too.

[matthewarmand]

FYI @cooperlees if you wanted to add something to support the Alpha image workflow, given the behavior we've seen in this issue it might be as easy as adding another job to the docker workflow:

     - name: Build and push latest_alpha tag
        if:
          ${{ github.event_name == 'release' && github.event.action == 'published' && github.event.release.prerelease }}
        uses: docker/build-push-action@v3
        with:
          context: .
          platforms: linux/amd64,linux/arm64
          push: true
          tags: pyfound/black:latest_alpha

Could call it latest_alpha, latest_prerelease, whatever. Then a docs update too, etc

[cooperlees]

FYI @cooperlees if you wanted to add something to support the Alpha image workflow, given the behavior we've seen in this issue it might be as easy as adding another job to the docker workflow:

     - name: Build and push latest_alpha tag
        if:
          ${{ github.event_name == 'release' && github.event.action == 'published' && github.event.release.prerelease }}
        uses: docker/build-push-action@v3
        with:
          context: .
          platforms: linux/amd64,linux/arm64
          push: true
          tags: pyfound/black:latest_alpha

Could call it latest_alpha, latest_prerelease, whatever. Then a docs update too, etc

Thanks for the good ideas. Will take into consideration and probably implement! PR welcome. More tags won't hurt.

[matthewarmand]

PR welcome. More tags won't hurt.

Have a gander: #3465