Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blackd: show default values for options #3712

Merged
merged 2 commits into from May 31, 2023
Merged

blackd: show default values for options #3712

merged 2 commits into from May 31, 2023

Conversation

joelsgp
Copy link
Contributor

@joelsgp joelsgp commented May 30, 2023 •
edited

I personally find this very useful.

Reference: https://click.palletsprojects.com/en/8.1.x/api/#click.Option

Description

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@github-actions
Copy link

github-actions bot commented May 30, 2023 •
edited

diff-shades reports zero changes comparing this PR (e7dba98) to main (a4032dc).

What is this? | Workflow run | diff-shades documentation

cooperlees
cooperlees approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks, I've always wished one could turn this on all option somewhere ...

Or it was the default, to show defaults ... haha :)

@cooperlees cooperlees merged commit a538ab7 into psf:main May 31, 2023
44 checks passed
@joelsgp joelsgp deleted the blackd-help-show-defaults branch June 1, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooperlees cooperlees cooperlees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joelsgp @cooperlees