Skip to content

Remove ENV_PATH on Black action completion. #3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 8, 2023
Merged

Remove ENV_PATH on Black action completion. #3759

merged 5 commits into from
Aug 8, 2023
+4 −0

Conversation

cjproud
Copy link
Contributor

@cjproud cjproud commented Jul 3, 2023

Description

Relates to #3708 by deleting the .black.env folder specified by ENV_PATH on action completion.

I had a difficult time replicating the issue above @JelleZijlstra and I can't see that any changes were made to stable that would effect this behaviour. Probably worth deleting that .black.env dir anyway?

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

Sorry, something went wrong.

@cjproud cjproud mentioned this pull request Jul 3, 2023
Closed
@ichard26 ichard26 added the C: integrations Editor plugins and other integrations label Jul 17, 2023
ichard26
ichard26 reviewed Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not sure how this would cause issues, but this is a good idea either way. Thanks for filing the PR!

Please add a changelog entry though.

action/main.py Outdated
@@ -73,5 +74,6 @@
stderr=STDOUT,
encoding="utf-8",
)
shutil.rmtree(ENV_PATH)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth passing ignore_errors=True to this call? An error is unlikely, but it also shouldn't fail the entire action IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I think an error is unlikely but yeah shouldn't fail the entire action.

@ichard26
Copy link
Collaborator

Don't mind the PyPy failures, it seems like a recent PyYAML release broke things on PyPy... :/

cjproud added 3 commits July 19, 2023 09:27
@cjproud
Add removal of env_path after completion.

Verified

This commit was signed with the committer’s verified signature.
ichard26 Richard Si
GPG key ID: 33F737A005EDF2DF
Verified
Learn about vigilant mode
6a94c69
@cjproud
Fix pre-commit error.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
39fdf6b
@cjproud
Add ignore_errors flag to rmtree.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
7d1222b
@cjproud
Added changlog entry.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
24eb187
@cjproud
Copy link
Contributor Author

cjproud commented Jul 19, 2023

@ichard26 I've added a changelog entry and the ignore_errors=True flag to the shutil.rmtree function 👍

hauntsaninja
hauntsaninja approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like another user confirmed the fix as well!

@hauntsaninja hauntsaninja merged commit c36e468 into psf:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichard26 ichard26

@hauntsaninja hauntsaninja

Assignees
No one assigned
Labels
C: integrations Editor plugins and other integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cjproud @ichard26 @hauntsaninja