Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty lines before docstrings in async functions #4132

Merged
merged 4 commits into from Jan 2, 2024
Merged

Remove empty lines before docstrings in async functions #4132

merged 4 commits into from Jan 2, 2024

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Dec 28, 2023 •
edited

Relates to #4043

hauntsaninja
hauntsaninja commented Dec 28, 2023
View reviewed changes
src/black/nodes.py
def is_funcdef(node: Node) -> bool:
return node.type == syms.funcdef


def is_function_or_class(node: Node) -> bool:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is suspicious since many async defs don't have async_funcdef, but this can be subject for different PR

edit: #4133

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 29, 2023 •
edited

diff-shades reports zero changes comparing this PR (5b84510) to main (fe33761).

What is this? | Workflow run | diff-shades documentation

@JelleZijlstra JelleZijlstra merged commit 8e0a9de into psf:main Jan 2, 2024
46 checks passed
@hauntsaninja hauntsaninja deleted the async-new-line branch January 2, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hauntsaninja @JelleZijlstra