Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't allow unparenthesizing walruses #4155

Merged
merged 6 commits into from Jan 17, 2024
Merged

fix: Don't allow unparenthesizing walruses #4155

merged 6 commits into from Jan 17, 2024

Conversation

RedGuy12
Copy link
Contributor

Description

Resolves #3758.

Checklist - did you ...

  • [y] Add an entry in CHANGES.md if necessary?
  • [y] Add / update tests if necessary?
  • [-] Add new / update outdated documentation?

RedGuy12 and others added 3 commits January 16, 2024 18:42
@RedGuy12
fix: Don't allow unparenthesizing walruses
e9eeb06 
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@RedGuy12
docs: Update CHANGES.md
4b9e82d 
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@RedGuy12
format
5346f29 
Signed-off-by: RedGuy12 <paul@reid-family.org>
JelleZijlstra
JelleZijlstra reviewed Jan 17, 2024
View reviewed changes
src/black/linegen.py Outdated Show resolved Hide resolved
@RedGuy12
Remove preview check
0ddd7c4 
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@RedGuy12
empty commit
a8c4c9f 
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@RedGuy12
fix: Don't add unnessecary walrus parentheses
f3bb847 
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@RedGuy12
Copy link
Contributor Author

It turns out that adding that check to maybe_make_parens_invisible_in_atom causes Black to add parenthesis around walruses where it's unnecessary. See the test failure (we didn't notice it previously since that test doesn't run with --preview). I moved the check to visit_dictsetmaker() where we can be sure it won't affect anything else.

JelleZijlstra
JelleZijlstra approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JelleZijlstra JelleZijlstra merged commit 9a331d6 into psf:main Jan 17, 2024
45 of 46 checks passed
@wizpig64
Copy link

Thanks @RedGuy12 for fixing my bug!

@RedGuy12 RedGuy12 deleted the gh-3758 branch January 18, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot parse assignment expression in preview style since 23.1
3 participants
@RedGuy12 @wizpig64 @JelleZijlstra