Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache file length #4176

Merged
merged 4 commits into from Jan 26, 2024
Merged

Fix cache file length #4176

merged 4 commits into from Jan 26, 2024

Conversation

JelleZijlstra
Copy link
Collaborator

  • Ensure total file length stays under 96
  • Hash the path only if it's too long
  • Proceed normally (with a warning) if the cache can't be read

Fixes #4172

Description

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

- Ensure total file length stays under 96
- Hash the path only if it's too long
- Proceed normally (with a warning) if the cache can't be read

Fixes psf#4172
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me and 32 chars is enough to be unique I believe.

@JelleZijlstra JelleZijlstra merged commit ed770ba into psf:main Jan 26, 2024
45 of 46 checks passed
@JelleZijlstra JelleZijlstra deleted the fixcache branch January 26, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache uses filenames that might be too long on some systems
3 participants