Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't remove comments along with parens #4218

Merged
merged 3 commits into from Feb 12, 2024
Merged

Conversation

RedGuy12
Copy link
Contributor

@RedGuy12 RedGuy12 commented Feb 8, 2024

Description

Resolves #3815

Checklist - did you ...

  • [y] Add an entry in CHANGES.md if necessary?
  • [y] Add / update tests if necessary?
  • [-] Add new / update outdated documentation?

Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@RedGuy12 RedGuy12 marked this pull request as draft February 8, 2024 17:15
@RedGuy12
Copy link
Contributor Author

RedGuy12 commented Feb 8, 2024

Failing test cases:

value.__dict__[
    key
] = "test"  # set some Thrift field to non-None in the struct aa bb cc dd ee

class A:
    def foo(self):
        for _ in range(10):
            aaaaaaaaaaaaaaaaaaa = bbbbbbbbbbbbbbb.cccccccccc(  # pylint: disable=no-member
                xxxxxxxxxxxx
            )

result = (
    1  # look ma, no comment migration xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
)

string_variable_name = (
    "a string that is waaaaaaaayyyyyyyy too long, even in parens, there's nothing you can do"  # noqa
)

Copy link

github-actions bot commented Feb 8, 2024

diff-shades reports zero changes comparing this PR (d87f4f0) to main (dab37a6).


What is this? | Workflow run | diff-shades documentation

Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@RedGuy12 RedGuy12 marked this pull request as ready for review February 9, 2024 16:22
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JelleZijlstra JelleZijlstra merged commit 8af4394 into psf:main Feb 12, 2024
46 checks passed
@sarvarfx
Copy link

plase what is

@RedGuy12 RedGuy12 deleted the gh-3815 branch February 18, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment is removed inside two pairs of parentheses
3 participants