Fix AST safety check false negative #4270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes psf#4268 Previously we would allow whitespace changes in all strings, now only in docstrings.
for more information, see https://pre-commit.ci
|
Seems like we got unlucky and someone added 3.12+ syntax to a diff-shades project just two hours ago (koaning/scikit-lego@64485a9#diff-db41f509a7991f7b7579a72fe7bdba315b5ab82bdde2f237c6a53d03396c0081R97 line 97). |
JelleZijlstra
added a commit
to ichard26/diff-shades
that referenced
this pull request
Mar 9, 2024
JelleZijlstra
added a commit
to ichard26/diff-shades
that referenced
this pull request
Mar 9, 2024
hauntsaninja
approved these changes
Mar 10, 2024
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
sumezulike
pushed a commit
to sumezulike/black
that referenced
this pull request
Mar 10, 2024
Fixes psf#4268 Previously we would allow whitespace changes in all strings, now only in docstrings. Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
JelleZijlstra
pushed a commit
that referenced
this pull request
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4268
Previously we would allow whitespace changes in all strings, now
only in docstrings.