Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple_choices vs multiple_choices_redirect #184

Open
sk1p opened this issue Apr 9, 2018 · 0 comments
Open

multiple_choices vs multiple_choices_redirect #184

sk1p opened this issue Apr 9, 2018 · 0 comments

Comments

@sk1p
Copy link
Contributor

sk1p commented Apr 9, 2018

While working on #183 and wondering why some tests take a long time, I noticed a bug in TestMultipleChoicesRedirects - the test accesses /multiple_choices_redirect/ but the SimpleApp server only defines /multiple_choices/ - so in this case, it falls back to the default 200 response in __call__. This may be hiding a real bug, I didn't really investigate further.

Maybe it would be a better idea to return a 404 or 500 error in cases of unknown URLs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sk1p