Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEAD clobbers GET cache #216

Open
jayvdb opened this issue Feb 7, 2020 · 0 comments
Open

HEAD clobbers GET cache #216

jayvdb opened this issue Feb 7, 2020 · 0 comments

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Feb 7, 2020

Mixing HEAD and GET requests for the same URL does not work. This isnt enabled by default, but afaics any use of the cacheable_methods to be anything other than GET will problematic.

This is a similar problem to POST #211 , and it is also solved in requests-cache because it uses a key which includes the method.

At the moment, invalidating_methods should include PATCH and POST. The former definitely invalidates the cache, and a POST to a URL are very likely to mean a cached value for GET of that URL will be outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant