Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document BaseCache expires value #251

Open
thenewguy opened this issue Jul 8, 2021 · 1 comment
Open

Document BaseCache expires value #251

thenewguy opened this issue Jul 8, 2021 · 1 comment

Comments

@thenewguy
Copy link

It would be helpful if the value for expires in BaseCache.set was documented. I couldn't find it and the redis/file caches aren't explicit.

Is the expires value guaranteed to be in UTC?

Related #250

@thenewguy thenewguy mentioned this issue Jul 8, 2021
@ionrock
Copy link
Contributor

ionrock commented Jul 8, 2021

As the date is typically provided by the server, we parse the timezone in order to try to make sure we're making the appropriate comparisons. I can imagine it could be better to convert to UTC, but I can also imagine there could be dragons there too.

In any case, if you look at the code and find a better answer that could use more docs and/or a change in behavior to use UTC, it seems like a legit change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants