Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move venv setup from pyperformance? #72

Open
gsnedders opened this issue Jul 3, 2020 · 1 comment
Open

Move venv setup from pyperformance? #72

gsnedders opened this issue Jul 3, 2020 · 1 comment

Comments

@gsnedders
Copy link

Playing around with pyperf, I can't help but think I'm going to end up reimplementing/importing a bunch of the pyperformance code around venvs. When testing performance of almost any Python code, I probably want to do it with it installed rather than from within a source tree, which means that any user of pyperf will end up implementing that.

I don't really know what makes the most sense API-wise; one obvious option would be a context manager which allows you to with runner.venv("requirements.txt") as env: env.bench_func("name", func) perhaps?

@vstinner
Copy link
Member

vstinner commented Jul 3, 2020

I'm not really excited by the idea of moving the venv feature from pyperformance into pyperf. Can't you use another tool to setup a venv to run benchmarks? I would prefer to restrict pyperf to a single task: run benchmark (and analyze results and compare results).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants