Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display the port of a server if the allocation alias is set. #4954

Open
1 task done
LaserKaspar opened this issue Dec 25, 2023 · 7 comments
Open
1 task done
Labels
feature request A request for a new feature.

Comments

@LaserKaspar
Copy link

LaserKaspar commented Dec 25, 2023

Is there an existing feature request for this?

  • I have searched the existing issues before opening this feature request.

Describe the feature you would like to see.

image
to
image

Describe the solution you'd like.

Either a permanent change, an option in .env of the panel, or some other config.

Additional context to this request.

Simple modification to ServerDetailsBlock.tsx#L66 I have on my instance. I don't know if this feature is in the interest of the general public, but I think it makes "normal" users of the panel less confused (we use aliases to assign them subdomains).

Anyways, great panel!

@LaserKaspar LaserKaspar added the feature request A request for a new feature. label Dec 25, 2023
@QuintenQVD0
Copy link
Contributor

QuintenQVD0 commented Dec 25, 2023

You can not allocate port 80?
Or any port lower then 1024?

The alias is just there to show a domain. So that for game servers you can connect to domain:port instad of needing to remember the ip.

@devnote-dev
Copy link
Contributor

That's irrelevant to the issue. Some tools/services/etc. require the port to be specified in cases that the domain (or alias in this case) is ambiguous. Removing it could lead to many different issues, and to be honest there isn't really a reason to do so other than visual aesthetics.

@LaserKaspar
Copy link
Author

LaserKaspar commented Dec 25, 2023

Ok, then I'll just keep it for my instance. The only reason for it is aesthetics and it's easier to copy/paste the thing you want. But as aliases are assigned per allocation, maybe a toggle option to hide a port on a specified allocation wouldn't break stuff for people that don't want it and the ones who do, can easily enable it?

The alias is just there to show a domain. So that for game servers you can connect to domain:port instad of needing to remember the ip.

Exactly, some game servers allow to specify a port via a srv record so you don't even have to remember the port.

@Jcodeerd
Copy link

Imo this should be toggleable per server, some servers might just use an A record instead of SRV for example

@LaserKaspar
Copy link
Author

LaserKaspar commented Dec 25, 2023

Maybe on a per egg basis? But per Server would also be great.

@Codixer
Copy link

Codixer commented Dec 26, 2023

I would say to have this per egg AND based on if the alias is set:

✅ - Alias
❌ - Feature enabled
❌ - Port still shows

❌ - Alias
✅ - Feature enabled
❌ - Port still shows

✅ - Alias
✅ - Feature enabled
✅ - Port is hidden.

@LaserKaspar
Copy link
Author

LaserKaspar commented Dec 27, 2023

Another possibility would be introducing a new kind of alias (maybe per Server) that just completely overwrites the Address field for the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A request for a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants