Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR CI statuses not fully in sync #484

Open
kamilpp opened this issue Aug 11, 2023 · 4 comments
Open

PR CI statuses not fully in sync #484

kamilpp opened this issue Aug 11, 2023 · 4 comments
Assignees
Labels

Comments

@kamilpp
Copy link

kamilpp commented Aug 11, 2023

I noticed that statuses for my repository are not always in sync.

On Github Pull Request page you can see that all checks passed:
image

In Trailer 1.8.4 on Mac OS (fewer positions here as I use "Exclude status items that include any of the terms below" filtering):
image
the statuses are sometimes neutral, sometimes green.

I expect all of them to be green when on Github these are green too.

Doing refresh from the menu does NOT help.
image

But doing full sync properly synchronises the statuses:
image
image

@kamilpp
Copy link
Author

kamilpp commented Aug 11, 2023

Just noticed 1.8.5 is out. I am going to test it and report if the issue occurs in this version too

@ptsochantaris
Copy link
Owner

Hi, thanks for raising 👍 I suspect the issue will be on the newer versions as well, as I haven't touched anything there (unless I did it by mistake :D) - I suspect this may have to do with the filtering occurring before the final status "stack" is assembled. The reason a full sync probably fixes this is because it only queries the statuses "shallowly" so the history that was being shown there (erroneously) probably never makes it to the local DB.

Question: This info isn't from a public repo, is it? Always helpful if I can try reproducing issues on the same data-set if at all possible :)

@ptsochantaris ptsochantaris self-assigned this Aug 11, 2023
@kamilpp
Copy link
Author

kamilpp commented Aug 12, 2023

It's a private repo which, unfortunately, I cannot share access to. If there is any other way to help with debugging, please let me know. I really appreciate Trailer app and all your effort.

@ptsochantaris
Copy link
Owner

No worries at all, but always worth me asking on such occasions :) I'll dig into this soon and update you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants