Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is failing on dev. #218

Closed
Eh2406 opened this issue May 6, 2024 · 2 comments · Fixed by #220
Closed

CI is failing on dev. #218

Eh2406 opened this issue May 6, 2024 · 2 comments · Fixed by #220

Comments

@Eh2406
Copy link
Member

Eh2406 commented May 6, 2024

We have recently successfully merged PR's that failed "Commit messages follow project guidelines" CI.

  1. https://github.com/pubgrub-rs/pubgrub/actions/runs/8914690905/job/24482780384
  2. https://github.com/pubgrub-rs/pubgrub/actions/runs/8926571377/job/24517897487
  3. https://github.com/pubgrub-rs/pubgrub/actions/runs/8973450833/job/24643647093

We should either give up on this check. Or fix CI (do not let them merge) and reset the dev branch (do not have them in the history) and reemerged the PR's.

@konstin
Copy link
Member

konstin commented May 6, 2024

Personally, i don't think it adds value, but I'm not opposed to having it. We should change it though to run directly when you put the PR up instead of later as it used to.

@Eh2406
Copy link
Member Author

Eh2406 commented May 6, 2024

Personally, i don't think it adds value, but I'm not opposed to having it.

Same

We should change it though to run directly when you put the PR up instead of later as it used to.

I found that very annoying because CI would basically always be ❌, especially annoying when the commits it was mad about where going to get squashed away.

I am very troubled that CI let things merge after finding ❌. Why did that happen and what else got through?

konstin added a commit to astral-sh/pubgrub that referenced this issue May 7, 2024
This change switches pbgrub to commit messages without prefix.

Closes pubgrub-rs#218
konstin added a commit to astral-sh/pubgrub that referenced this issue May 7, 2024
This change switches pbgrub to commit messages without prefix.

Closes pubgrub-rs#218
github-merge-queue bot pushed a commit that referenced this issue May 15, 2024
This change switches pbgrub to commit messages without prefix.

Closes #218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants