New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI is failing on dev. #218
Comments
Personally, i don't think it adds value, but I'm not opposed to having it. We should change it though to run directly when you put the PR up instead of later as it used to. |
Same
I found that very annoying because CI would basically always be ❌, especially annoying when the commits it was mad about where going to get squashed away. I am very troubled that CI let things merge after finding ❌. Why did that happen and what else got through? |
This change switches pbgrub to commit messages without prefix. Closes pubgrub-rs#218
This change switches pbgrub to commit messages without prefix. Closes pubgrub-rs#218
This change switches pbgrub to commit messages without prefix. Closes #218
We have recently successfully merged PR's that failed "Commit messages follow project guidelines" CI.
We should either give up on this check. Or fix CI (do not let them merge) and reset the dev branch (do not have them in the history) and reemerged the PR's.
The text was updated successfully, but these errors were encountered: