Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛹 Feature: Selektion in KolTableStateless #5859

Closed
3 tasks done
laske185 opened this issue Jan 5, 2024 · 1 comment · Fixed by #6389
Closed
3 tasks done

🛹 Feature: Selektion in KolTableStateless #5859

laske185 opened this issue Jan 5, 2024 · 1 comment · Fixed by #6389
Assignees
@sdvg
Labels
feature New feature or request
Milestone
Table improvement

Comments

@laske185
Copy link
Contributor

laske185 commented Jan 5, 2024 •
edited by sdvg

Die im Ticket #5858 erstellte KolTableStateless soll um eine Selektion von Reihen erweitert werden.

Akzeptanzkriterien

  • neues Attribut: _selection
    • Typ:
 {
  label: (row: T) => string,
  keyPropertyName: string, // default = `key`
  selectedKeys?: string[]
}
  • Neue Spalte mit Checkboxen
    • ohne Überschrift (wird noch im BITV-Team besprochen)
    • Die KolInputCheckbox nutzen
    • Das Label der Checkbox wird durch die Labelfunktion im selection-Objekt erzeugt
  • Callback-Funktion onSelectionChanged und Event onSelectionChange gibt alle aktuell selektierte Rows (komplette Objekte) zurück
    • in weiteren Iterationen könnte ein onRowSelected oder onRowUnselected hinzukommen
@laske185 laske185 added the feature New feature or request label Jan 5, 2024
@laske185 laske185 added this to the Table improvement milestone Jan 5, 2024
This was referenced Jan 5, 2024
Open
Closed
@sdvg sdvg changed the title 🛹 Feature: Selektion in KolTableStateles 🛹 Feature: Selektion in KolTableStateless Jan 5, 2024
@deleonio deleonio mentioned this issue Mar 26, 2024
Closed
3 tasks
@sdvg sdvg self-assigned this Apr 26, 2024
sdvg added a commit that referenced this issue Apr 26, 2024
@sdvg
Introduce property (table) selection
c0db424 
Refs: #5859
sdvg added a commit that referenced this issue Apr 30, 2024
@sdvg
Add selection to table stateless
ceaf42b 
Refs: #5859
@sdvg
Copy link
Member

sdvg commented Apr 30, 2024

In der Spec (oben) haben wir geschrieben:

Callback-Funktion onSelectionChanged und Event onSelectionChange gibt alle aktuell selektierte Rows (komplette Objekte) zurück

Ich würde das von "komplette Objekte" erst einmal zu "selectedKeys" ändern. Das scheint mir für die Stateless-Tabelle sinnvoller, weil wir hier auch nur selectedKeys als Prop rein geben und der State von außen gemanaged wird. Bei der Stateful-Tabelle halte ich "komplette Objekte" wiederum für sinnvoll.

sdvg added a commit that referenced this issue Apr 30, 2024
@sdvg
Add selection-change event
5718df4 
Refs: #5859
sdvg added a commit that referenced this issue Apr 30, 2024
@sdvg
Add onSelectionChange callback
9834a29 
Refs: #5859
sdvg added a commit that referenced this issue Apr 30, 2024
@sdvg
Add documentation for _selection prop
0243763 
Refs: #5859
@sdvg sdvg linked a pull request Apr 30, 2024 that will close this issue
Implement selection feature for TableStateless #6389
Merged
5 tasks
deleonio added a commit that referenced this issue May 8, 2024
@deleonio
pull develop branch
d08e1ed 
Refs: #5859
sdvg added a commit that referenced this issue May 14, 2024
@sdvg
Fix type for table selection label function argument
5ec89be 
Refs: #5859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdvg sdvg

Labels
feature New feature or request
Projects
KoliBri Board
Status: ✅ Done
Milestone
Table improvement
Development

Successfully merging a pull request may close this issue.

Implement selection feature for TableStateless public-ui/kolibri
2 participants
@sdvg @laske185